[detector] Implemented Box Detector #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x1
reviewed
Aug 23, 2024
0x1
reviewed
Aug 23, 2024
|
Box also has OAuth, thoughts on adding that also? |
remove PII details of user.
|
@abmussani is this ready for another review? |
* main: (127 commits) Update SaladCloud description (trufflesecurity#3399) fix tests (trufflesecurity#3400) [chore] Update custom detector default description (trufflesecurity#3398) add description to salad (trufflesecurity#3397) Add detector for SaladCloud API Keys (trufflesecurity#3273) fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393) Add SliceContainsString common util (trufflesecurity#3395) fix: pr template link to golangci-lint (trufflesecurity#3392) fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389) Separate detector tests into unit/integration (trufflesecurity#3274) Manually upgrade github dep (trufflesecurity#3387) Updated Fastly Personal Token Detector (trufflesecurity#3386) fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391) [Fix] Snowflake privatelink Support (trufflesecurity#3286) Enhanced the easyinsight detector (trufflesecurity#3384) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) ... # Conflicts: # pkg/engine/defaults.go # pkg/pb/detectorspb/detectors.pb.go # proto/detectors.proto
Implemented description for Box detectors. Separated out test for Box detectors.
@0x1 This PR now includes, Detector for Box Token and Box Oauth mechanism. |
ahrav
reviewed
Oct 14, 2024
ahrav
approved these changes
Oct 14, 2024
* main: feat: propagate file info in log context (trufflesecurity#3405) fix(deps): update module github.com/xanzy/go-gitlab to v0.112.0 (trufflesecurity#3410) fix(deps): update module github.com/getsentry/sentry-go to v0.29.1 (trufflesecurity#3408) fix(deps): update module github.com/gabriel-vasile/mimetype to v1.4.6 (trufflesecurity#3407)
kashifkhan0771
approved these changes
Oct 15, 2024
|
Great work @abmussani |
|
Seeing to many false positives matches for this due to |
bugbaba
reviewed
Oct 16, 2024
| s1 := detectors.Result{ | ||
| DetectorType: detectorspb.DetectorType_BoxOauth, | ||
| Raw: []byte(resIdMatch), | ||
| RawV2: []byte(resIdMatch + resSecretMatch), |
There was a problem hiding this comment.
@abmussani A separator between the two matches would make it more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds up a new detector for "Box" Service. Please note that, by default, Box tokens has expiry of 60 minutes. To run the test, token might be needed to regenerated and updated in vault.
This PR also includes Detector for Box Oauth service.
Documentation: https://developer.box.com/reference/get-authorize/
Checklist:
make test-community)?make lintthis requires golangci-lint)?